Old 09-05-2008, 16:46   #1 (permalink)
Ehab
is gta4 addicted..
 
Ehab's Avatar
 
Join Date: Apr 2008
Location: San Diego, CA
Posts: 24
floats

web stigma

first site completely hand-written css and html.
nothing but fireworks and notepad++, did not open dreamweaver once

try to ignore that it is horribly ugly looking for now and somehow, the client is still impressed by it. i made the mistake of letting him sit right next to me as he asked me to edit a few things and could not help cringing every time things went out of line or looked crooked or nasty, like how everything is squeezed together at the top with not enough space (just so ppl with 800*600 or 1024*768 could see it all in one take! according to the smart fucker) ..and how those color bullets looked pixellated and the header still needs work and the thumbnails need work and the copy is too small and underspaced.. but he liked it and wanted it all done and rushed right then and there. .such an annoying little shit. regardless of all that.. i was wondering what you guys thought of the code

for a first timer.. i found that positioning absolute or relative was a little confusing and unstable and i used floats for mostly all of my divs. i still cant clearly distinguish when i need to use a <span> tag instead of a <div> tag.. (i did not use any in this website) ..and also when to use a class instead of an id (did not use any classes either) ..but all in all i think it is a fair first attempt.

advice/criticism appreciated..
  Reply With Quote
Old 09-05-2008, 17:02   #2 (permalink)
seen.to
unusual suspect ™
 
seen.to's Avatar
 
Join Date: Jul 2004
Location: DE, USA
Posts: 2,511
So, avoiding discussing the actual design, congratulations on your first hand-coded, table free site.

I've certainly seen worse code (hell I have to work with worse code every day).

The logo could be a background image and it's usual for the logo to link to the home page - people get used to this stuff. Same with the header, make it a background image and cut down on some markup. Same again with the featured clients but not as much so as these will likely change more often. Think more about your alt definitions as these should provide an alternative to the image for someone that cannot, for whatever reason, view the image.

You should provide a text equivalent for your image links (within ul#buttons) - that would be a good time to use a span with a class such as 'hider' and then use CSS to hide the text.

Use an ID when something is only going to be used once on the page, use a class if it's going to be used more than once.

Good for a first attempt at the XHTML though, well done.

I was about to move onto the CSS bt it's 5 o'clock so I'm going home
__________________
  Reply With Quote
Old 09-05-2008, 17:24   #3 (permalink)
Ehab
is gta4 addicted..
 
Ehab's Avatar
 
Join Date: Apr 2008
Location: San Diego, CA
Posts: 24
thanks for the quick and positive feedback man

yeah that text equivalent for the image links tip should be a good idea, it would make the website more 'semantic' i guess, according to what ive been reading. and i know that much about ids and classes, i guess i shouldve rephrased my question, but i just dont see that i would need to use them at all is what im saying.

the first thing i read about css and html, as a basic rule, is to use css to present the content that goes in the html. html = content, css= presentation. keeping that in mind, i thought the images for the logo and header should go into the html, as they are more content than presentation.. and then to position them using css. what would setting them as background images benefit me, really ? and ill definitley link that header back to the home page too, i just forgot to do that this time.
  Reply With Quote
Reply



Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)
 
Thread Tools Search this Thread
Search this Thread:

Advanced Search


Contact Us - Web Design Forums - Archive - Top
Search Engine Optimization by vBSEO 3.0.0 RC8