Web Design Forums

campbell · 17-04-2008, 20:41

I have a contact form and I want to have multiple recipients but I keep seeing scripts like this, which don't secure the email address of the recipients.

My current script is like this in the contact form file. However, the email isn;t being sent to the selected recipient. How can I fix that?

Quote:

<tr>
<td><p>Recipient</p></td>
<td><select name="Recipient" size="1" id="Recipient">
<option value="test1">John Doe 1</option>
<option value="test2">John Doe 2</option>
<option value="test3">John Doe 3</option>
</select>
</td>
</tr>

And like this in the processing script.

Quote:

$emailTo = 'test1'=> 'test1@live.com','test2'=> 'test2@hotmail.com','test3'=> 'test3@yahoo.com';
$rows[0]->extraemail = $emails[$_POST['Recipient']];

pgo · 17-04-2008, 22:49

How is that not securing the email address again? I don't see any emails in that HTML.

ooyes · 18-04-2008, 05:17

yes what do you mean i dont see any in the HTML too

campbell · 18-04-2008, 16:12

Sorry my mad. I keep seeing scripts like this.

Quote:

<tr>
<td><p>Recipient</p></td>
<td><select name="Recipient" size="1" id="Recipient">
<option value="'test1@live.com">John Doe 1</option>
<option value="test2@hotmail.com">John Doe 2</option>
<option value="test3@yahoo.com">John Doe 3</option>
</select>
</td>
</tr>

However, I know that script can get those email address spam bombed.

So I tried that script shown above, but it isn't sending the emails. So what do I do?

haku · 19-04-2008, 00:24

You can use this:

Code:

<?php
   switch($_POST['Recipient']
   {
      case "test1":
         $email_to = "test1@live.com";
         break;
      case "test2:
         $email_to = "test2@hotmail.com;
         break:
      case "test3":
         $email_to = "test3@yahoo.com";
         break;
   }
?>

campbell · 19-04-2008, 23:05

Here is the full script. I tried that thing you told me to insert, but it never worked.

Quote:

<?PHP
################################################## ####
# #
# Forms To Go 3.2.5 #
# Bebosoft #
# #
################################################## ####

DEFINE('kOptional', true);
DEFINE('kMandatory', false);

error_reporting(E_ERROR | E_WARNING | E_PARSE);
ini_set('track_errors', true);

function DoStripSlashes($FieldValue)
{
if ( get_magic_quotes_gpc() ) {
if (is_array($FieldValue) ) {
return array_map('DoStripSlashes', $FieldValue);
} else {
return stripslashes($FieldValue);
}
} else {
return $FieldValue;
}
}

#----------
# FilterCChars:

function FilterCChars($TheString)
{
return preg_replace('/[\x00-\x1F]/', '', $TheString);
}

#----------
# Validate: Email

function check_email($email, $optional)
{
if ( (strlen($email) == 0) && ($optional === kOptional) ) {
return true;
} elseif ( eregi("^[_a-z0-9-]+(\.[_a-z0-9-]+)*@[a-z0-9-]+(\.[a-z0-9-]+)*(\.[a-z]{2,4})$", $email) ) {
return true;
} else {
return false;
}
}

if (isset($_SERVER['HTTP_X_FORWARDED_FOR'])) {
$ClientIP = $_SERVER['HTTP_X_FORWARDED_FOR'];
} else {
$ClientIP = $_SERVER['REMOTE_ADDR'];
}

$FTGName = DoStripSlashes( $_REQUEST['Name'] );
$FTGEmail = DoStripSlashes( $_REQUEST['Email'] );
$FTGSubject = DoStripSlashes( $_REQUEST['Subject'] );
$FTGRecipient = DoStripSlashes( $_REQUEST['Recipient'] );
$FTGMessage = DoStripSlashes( $_REQUEST['Message'] );
$FTGSubmit = DoStripSlashes( $_REQUEST['Submit'] );

# Fields Validations

$ValidationFailed = false;

if (!check_email($FTGEmail, kOptional)) {
$ValidationFailed = true;
$FTGEmail_errmsg = 'The email address entered is invalid. ';
$ErrorList .= $FTGEmail_errmsg . '<br/>';
}

# Include message in error page and dump it to the browser

if ($ValidationFailed === true) {

$ErrorPage = '<html><head><title>Error</title></head><body>Errors found: </body></html>';

$ErrorPage = str_replace('', $ErrorList, $ErrorPage);
$ErrorPage = str_replace('', $FTGName, $ErrorPage);
$ErrorPage = str_replace('', $FTGEmail, $ErrorPage);
$ErrorPage = str_replace('', $FTGSubject, $ErrorPage);
$ErrorPage = str_replace('', $FTGRecipient, $ErrorPage);
$ErrorPage = str_replace('', $FTGMessage, $ErrorPage);
$ErrorPage = str_replace('', $FTGSubmit, $ErrorPage);
$ErrorPage = str_replace('', $FTGEmail_errmsg, $ErrorPage);

echo $ErrorPage;
exit;

}
# Email to Form Owner

$emailSubject = FilterCChars("Mount Olive Contact Form");

$emailBody = "Name : $FTGName\n"
. "Email : $FTGEmail\n"
. "Subject : $FTGSubject\n"
. "Recipient : $FTGRecipient\n"
. "Message : $FTGMessage\n"
. "";

$emailTo = switch($_POST['Recipient']
{
case "test1":
$email_to = "test1@live.com";
break;
case "test2":
$email_to = "test2@hotmail.com";
break;
case "test3":
$email_to = "test3@yahoo.com";
break;
}

$emailFrom = FilterCChars("noreply@mountoliveadventist.org");

$emailHeader = "From: $emailFrom\n"
. "MIME-Version: 1.0\n"
. "Content-type: text/plain; charset=\"ISO-8859-1\"\n"
. "Content-transfer-encoding: 8bit\n";

mail($emailTo, $emailSubject, $emailBody, $emailHeader);

# Include message in the success page and dump it to the browser

$SuccessPage = '<html><head><title>Success</title></head><body>Form submitted successfully. It will be reviewed soon.</body></html>';

$SuccessPage = str_replace('', $FTGName, $SuccessPage);
$SuccessPage = str_replace('', $FTGEmail, $SuccessPage);
$SuccessPage = str_replace('', $FTGSubject, $SuccessPage);
$SuccessPage = str_replace('', $FTGRecipient, $SuccessPage);
$SuccessPage = str_replace('', $FTGMessage, $SuccessPage);
$SuccessPage = str_replace('', $FTGSubmit, $SuccessPage);

echo $SuccessPage;
exit;
?>

pgo · 20-04-2008, 03:32

You have to at least do more than copy/paste it in and then ditch it if it doesn't work.

Try learning how it works and fixing it. It's very easy. The values "test1" and so on are not defined in your form, so obviously the switch function isn't going to make a match.

campbell · 20-04-2008, 12:41

Quote:

<tr>
<td><p>Recipient</p></td>
<td><select name="Recipient" size="1" id="Recipient">
<option value="test1">John Doe 1</option>
<option value="test2">John Doe 2</option>
<option value="test3">John Doe 3</option>
</select>
</td>
</tr>

I did have the values in the main form assigned like this. It still didn;t work.

haku · 21-04-2008, 00:16

At least some of your problems lie here:

Code:

$emailTo = switch($_POST['Recipient']
{
case "test1":
$email_to = "test1@live.com";
break;
case "test2":
$email_to = "test2@hotmail.com";
break;
case "test3":
$email_to = "test3@yahoo.com";
break;
}

You are missing a bracket, and you are declaring $email_to outside the function as well as inside the function. I don't know if you can set it outside the function like that, but if you can, then you will need to remove it from inside the function. But I think you should just define it inside the function.

17-04-2008, 22:49	#2 (permalink)
pgo Moderator Join Date: Jan 2005 Location: Brooklyn, NYC Posts: 11,869	How is that not securing the email address again? I don't see any emails in that HTML. __________________ Find good advice in the beginners web design thread. patrick o'neill web developer \| blog \| spam humor

19-04-2008, 00:24	#5 (permalink)
haku shiro Join Date: Aug 2007 Location: Yokohama, Japan Posts: 1,306	You can use this: Code: <?php switch($_POST['Recipient'] { case "test1": $email_to = "test1@live.com"; break; case "test2: $email_to = "test2@hotmail.com; break: case "test3": $email_to = "test3@yahoo.com"; break; } ?>

20-04-2008, 03:32	#7 (permalink)
pgo Moderator Join Date: Jan 2005 Location: Brooklyn, NYC Posts: 11,869	You have to at least do more than copy/paste it in and then ditch it if it doesn't work. Try learning how it works and fixing it. It's very easy. The values "test1" and so on are not defined in your form, so obviously the switch function isn't going to make a match. __________________ Find good advice in the beginners web design thread. patrick o'neill web developer \| blog \| spam humor

21-04-2008, 00:16	#9 (permalink)
haku shiro Join Date: Aug 2007 Location: Yokohama, Japan Posts: 1,306	At least some of your problems lie here: Code: $emailTo = switch($_POST['Recipient'] { case "test1": $email_to = "test1@live.com"; break; case "test2": $email_to = "test2@hotmail.com"; break; case "test3": $email_to = "test3@yahoo.com"; break; } You are missing a bracket, and you are declaring $email_to outside the function as well as inside the function. I don't know if you can set it outside the function like that, but if you can, then you will need to remove it from inside the function. But I think you should just define it inside the function.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search

18-04-2008, 05:17	#3 (permalink)
ooyes website design Join Date: Jan 2008 Location: London Posts: 5	yes what do you mean i dont see any in the HTML too

Currently Active Users Viewing This Thread: 1 (0 members and 1 guests)