[gray]

getting loads of notices regarding undefined variables, and i have been doing this to get rid:

PHP Code:

if (isset($_GET['variable']))
{
  $variable= $_GET['variable'];
}
else
{
  $variable= "";
} 


just wondered if this was the correct way? (variables are coming from url strings and cannot be set in the code)

[d3mcfadden]

$variable = isset($_GET['variable']) ? $_GET['variable'] : null;

[aristoworks]

You could always just turn the errors off if you don't want to be bothered.

error_reporting(0);

[MikeMackay]

Originally Posted by aristoworks

You could always just turn the errors off if you don't want to be bothered.

error_reporting(0);

Personally I think the errors should always be reported as it will help maintain cleaner code and will notify you otherwise. I'd recommend going with d3mcfadden's advice using the Ternary Operator. Nice, clean, simple.

- Mike

[gray]

if my car makes weird noises i could always turn the radio up but id pay in the long run

[aristoworks]

Just offering a simple solution. Obviously it's best to fix the problem BUT if he's got a simple site and incorporates an older script and the only errors he gets is a bunch of undefined variables technically there's no harm with turning those errors off.

It's important to understand how PHP's built in error reporting works anyways - I'd never let a client site go live fully opened up as naturally there may be a bump or 2 in the road. Build a custom error_log scheme and that will let you know whats wrong and not make your client look like an amature.

[MikeMackay]

Originally Posted by aristoworks

Just offering a simple solution.

Absolutely and it's always good to have a choice, no criticism in my post was intended.

- Mike

[RJP]

Just to clarify... the reports you are getting about undefined variables are "NOTICES"... which is the lowest level of reports. They are "things that you oughtta know", but they don't really have any impact on your script.

You can change the specified reporting level to not display NOTICE reports, but still report "warnings" and "errors". This will get rid of these not so important messages, but will still help you when you have real problems.

-Ryan