[finbarr]

this is the link as written by previous designer:

<a href="#" onMouseDown="MM_openBrWindow('www.linkhere','','to olbar=yes,scrollbars=yes,width=640,height=400')">B ook
online</a>
because the href has an # associated with it, clicking the link just refreshes the page/sends you back to the top.

But I cant figure out how the link should be written... I think I'm having a braindead afternoon.

Can anyone help?

[smallbeer]

return false; ?

[finbarr]

Originally Posted by smallbeer

return false; ?

that basically ignores the href link meaning the browser goes to the 'MM_openBrWindow' instruction?
and does it go in the href "insert here"?

or will putting 'javascript' in the href work?

[smallbeer]

what?

<a href="#" onMouseDown="MM_openBrWindow('www.linkhere','','to olbar=yes,scr ollbars=yes,width=640,height=400');return false;">Book
online</a>

[Stickman]

Originally Posted by finbarr

that basically ignores the href link meaning the browser goes to the 'MM_openBrWindow' instruction?
and does it go in the href "insert here"?

or will putting 'javascript' in the href work?

Return false means the link action is cancelled, so you go nowhere.

[Stickman]

Fwiw, I use a bit of script to detect the link type and launch popups if called. So if js is turned off, the user gets there anyway.

<a href="pop.htm" type="popup" title="Launch popup">

Very nice it is too.

[finbarr]

Originally Posted by smallbeer

what?

<a href="#" onMouseDown="MM_openBrWindow('www.linkhere','','to olbar=yes,scr ollbars=yes,width=640,height=400');return false;">Book
online</a>

Sorry, S if I'm sounding like a thicko!

The way I understand it is that the browser is reading the href="#" instead of going to the MM_Open command... right?

by putting in return false at the end, does that ensure that the browser reads the MM_open?

to clarify: I want the browser to read the MM_Open and ignore the href="#"

[smallbeer]

did you try it?

return false stops you browser doing what it would otherwise have done. in this case going to #

[finbarr]

having probelms with the system here so wont be able to check until tomorrow...

thanks for the help anyway

[i3lance]

Ok firstly make sure this is in your header:

var newwindow;
function openwindow(url)
{
newwindow=window.open(url,'name','toolbar=yes, scrollbars=yes, height=640,width=400');
if (window.focus) {newwindow.focus()}
}

Then have this as your link mate:

<a href="page.html" onClick="openwindow('page.html'); return false;">Book online</a>

You asked Fin I answered!

Having the link this way also lets people to have JS disabled browse your links.

[stickmus]

Why have the return false in the onClick? put it in the function. But you really shoud be doing it like stickman does, progressive enhancement and all that.

[i3lance]

Originally Posted by stickmus

Why have the return false in the onClick? put it in the function. But you really shoud be doing it like stickman does, progressive enhancement and all that.

True, wanna post a link mate?

[finbarr]

ended up just doing away with function and putting window.open on the link.

It was being messed up somehow by the in-house CMS and no matter what I tried it wouldnt work with the function.
The site is going to be overhauled very soon so they arent too worried about the solution in the interim

[i3lance]

As long as you found a way matey